Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying output field name for simple aggregation #538

Merged
merged 2 commits into from
Jan 31, 2021
Merged

Allow specifying output field name for simple aggregation #538

merged 2 commits into from
Jan 31, 2021

Conversation

bmaggard
Copy link
Contributor

@bmaggard bmaggard commented Jan 31, 2021 •
edited
Loading

Changes

Implemented the feature requested in issue #370

Checklist

Checklist for for pull requests including new code and/or changes to existing code...

  • Code
    • Includes unit tests
    • New functions have docstrings with examples that can be run with doctest
    • New functions are included in API docs
    • Docstrings include notes for any changes to API or behaviour
    • All changes documented in docs/changes.rst
  • Testing
    • (Optional) Tested local against remote servers
    • Travis CI passes (unit tests run under Linux)
    • AppVeyor CI passes (unit tests run under Windows)
    • Unit test coverage has not decreased (see Coveralls)
  • Changes
    • (Optional) Just a proof of concept
    • (Optional) Work in progress
    • Ready to review
    • Ready to merge

@coveralls
Copy link

coveralls commented Jan 31, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 91.826% when pulling 09825e3 on bmaggard:issue_370 into 69f4b45 on petl-developers:master.

juarezr
juarezr requested changes Jan 31, 2021
View reviewed changes
Copy link
Member

@juarezr juarezr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement.

Please:

  • Include your name/nick in petl/docs/acknowledgments.rst
  • Include a description for your change in petl/docs/changes.rst into version 1.7.2

@bmaggard bmaggard requested a review from juarezr January 31, 2021 20:46
@juarezr juarezr merged commit 0a40801 into petl-developers:master Jan 31, 2021
@bmaggard bmaggard deleted the issue_370 branch January 31, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juarezr juarezr juarezr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmaggard @coveralls @juarezr