Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other improvements #99

Merged
merged 6 commits into from
May 23, 2024
Merged

Other improvements #99

merged 6 commits into from
May 23, 2024

Conversation

ricardoevvargas
Copy link
Collaborator

By creating this pull request, I confirm that I have read and fully accept and agree with one of the Petrobras' Contributor License Agreements (CLAs):

Our CLAs are based on the Apache Software Foundation's CLAs:


This PR is related to PR #98 and proposes the following:

pivettamarcos and others added 6 commits April 23, 2024 15:58
- Remove windows related conda packages
- use os.path.join in all instances
Make code platform independent
…heir respective versions to be installed. Dependencies can be resolved by conda in different ways on different operating systems.
@ricardoevvargas
Copy link
Collaborator Author

@afraniomelo, could you assess whether this less restrictive environment.yml is an appropriate evolution while we don't complete the study on alternatives?

@ricardoevvargas
Copy link
Collaborator Author

@pivettamarcos, could you confirm that on OS other than Windows conda generates a virtual environment from this less restrictive environment.yml (proposed in this PR) in which Jupyter notebooks contained in the 3W project work without errors? I don't have easy access to other operational systems nowadays but this can be done with $ conda env create -f environment.yml.

I'm talking about the following Jupyter notebooks:

Important:

@ricardoevvargas
Copy link
Collaborator Author

It seems that @afraniomelo and @pivettamarcos weren't available, but I had access to a computer with Fedora 34 and I was able to confirm that at least in this Linux distribution, conda generates a virtual environment from this less restrictive environment.yml (proposed in this PR) in which the 2 Jupyter notebooks mentioned work without errors. In fact, I noticed a problem in the overview created by @AndrePauloFM, specifically in the use of pandas_profiling, which has been replaced by ydata-profiling. As this is another problem, I'll create an issue to deal with it and merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants