New form + routing + bug fixes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2017 18:28
Fix the bug with the same timestamp (load the store before adding new record) - it seems that server protection doesn't work Fix the bug with empty game table
HonzaTuron
reviewed
Jun 4, 2017
| @@ -23,6 +23,8 @@ Ext.define('Enif.controller.StoreLoadController', { | |||
| // clear the filters on the store before loading | |||
| gamesStore.clearFilter(); | |||
There was a problem hiding this comment.
Is double clearFilter call necessary?
There was a problem hiding this comment.
I know about that and I don't know, the comment says clear the filter before loading, I didn't wanted to investigate further
|
By the power given by god I shall merge this pull request without any approved review. |
|
:-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.