Fleximod test #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resets find_input_name_idx to no_exist_idx after it is modified by const_get_index. Fixes the bug resulted in variables getting a huge <0 index value instead of -1, which caused an error in physics_read_data. closes ESCOMP#237 Describe any changes made to build system: N/A Describe any changes made to the namelist: N/A List any changes to the defaults for the boundary datasets: N/A Describe any substantial timing or memory changes: N/A Code reviewed by: nusbaume, mwaxmonsky List all existing files that have been modified, old files eliminated, new files added and describe the changes: M src/physics/utils/physics_data.F90 * Reset find_input_name_idx to no_exist_idx after call to const_get_index M cime_config/config_component.xml * No longer include chemistry linked libs by default If there were any failures reported from running test_driver.sh on any test platform, and check that these failures have been OK'd by the gatekeeper, then copy the lines from the td.*.status files for the failed tests to the appropriate machine below. All failed tests must be justified. derecho/intel/aux_cam derecho/gnu/aux_cam All tests pass. Summarize any changes to answers, i.e., what code configurations: N/A what platforms/compilers: N/A nature of change (roundoff; larger than roundoff but same climate; new climate): N/A
nusbaume
pushed a commit
to ESCOMP/CAM-SIMA
that referenced
this pull request
Oct 17, 2024
Brings in the new PR template for CAM-SIMA. See: peverwhee#2 for what it looks like upon opening a PR (though it's not wildly different from the markdown...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag name (required for main):
Originator(s):
Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):
Describe any changes made to build system:
Describe any changes made to the namelist:
List any changes to the defaults for the input datasets (e.g. boundary datasets):
List all files eliminated and why:
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compare to the existing-test-failures.txt file),
have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
CAM-SIMA date used for the baseline comparison tests if different than latest: