-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foolproof sitepackages_dir_cmd, and raise error when it fails #210
base: master
Are you sure you want to change the base?
Conversation
I ran into this today. I'd really like to see this fix applied, since it seems to break my current workflow. |
@ashwinvis Are you still interested in this? The appveyor tests are failing, which should be looked at. |
I can update the PR. Seems like #214 is fixing the CI, so I can rebase the branch if it will be merged. Sounds good? |
Sure, if that works I'm fine with it. The error in question is "ImportError: No module named pew._utils" which seems a bit more fundamental, though (although I don't see how it relates to this PR). |
FWIW, I just tested master on my local (Windows) PC, and I see the test failures that #214 is addressing, but not the Ultimately, I'm happy to approve this PR if the tests pass, but I can't make the decision to accept a PR with test failures, sorry. |
Can you retrigger the Appveyor CI - it could be something to do with their Python build / environment a year ago, which hopefully got fixed now. |
The only way I have of doing that is to close & reopen the PR, which I'll do. I don't have admin access to the Appveyor setup. |
Sigh, that looks even worse 🙁 I don't have much more time to spend on this right now. Looks like there's some not-insignificant bitrot to address here :-( Probably something to pick up first on #218... |
aed9c40
to
2d9e18a
Compare
Fixes #209