Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default caching in the pex tool is incorrect #24

Closed
wickman opened this issue Oct 28, 2014 · 3 comments
Closed

default caching in the pex tool is incorrect #24

wickman opened this issue Oct 28, 2014 · 3 comments
Labels

Comments

@wickman
Copy link
Contributor

wickman commented Oct 28, 2014

if you do pex --repo=/tmp/path/to/my/repo -r req and that requirement gets pulled into $PEX_ROOT/build, subsequent calls to 'pex -r req' will resolve to the version in $PEX_ROOT/build if 'req' is ahead of the PyPI tip. this is unexpected default behavior. the pex tool should only do this if --cache/--cache-ttl are both specified.

wickman referenced this issue in rouge8/pex Nov 21, 2014
Rework the `pex` command to, in order:

1. Build source dirs.
2. Add built packages to requirements.
3. Resolve requirements, without using any caching.

This is a quick hack to workaround pex-tool#22.
@wickman wickman added the bug label Apr 4, 2015
wickman added a commit that referenced this issue Apr 4, 2015
@sholsapp
Copy link
Contributor

sholsapp commented Apr 6, 2015

@wickman +1 to this issue -- that was a big surprise. :)

@wickman
Copy link
Contributor Author

wickman commented Apr 13, 2015

https://rbcommons.com/s/twitter/r/2076/ addresses this for the most part (source packages are always built...but it removes the -s option in favor of being uniform with pip.)

@wickman
Copy link
Contributor Author

wickman commented Apr 14, 2015

should be fixed by c93ea9c.

@wickman wickman closed this as completed Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants