Add support for --pip-version latest.
#2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows an opt-in to always using the latest Pip supported by Pex when upgrading through Pex versions. This is generally desirable for most Pex consumers.
benjyw
approved these changes
Apr 17, 2023
| @@ -68,7 +78,8 @@ def values(cls): | |||
| return cls._values | |||
|
|
|||
| v20_3_4_patched = PipVersionValue( | |||
| version="20.3.4-patched", | |||
| name="20.3.4-patched", | |||
| version="20.3.4+patched", | |||
There was a problem hiding this comment.
I didn't grok why the name/version distinction is necessary. For the currently supported versions at least ordering by the (pre-change) version seems like it would work? And I don't see anything in the versions of pip releases that would defeat it even if we added new versions in the future.
There was a problem hiding this comment.
The 20.3.4-patched is not a valid PEP-440 version (fails to parse with modern packaging). I did not want to break the CLI value though; so split the name from the version conceptually to handle this 1 case.
CI overrides the default Pip version; so this slightly off-topic test becomes more trouble than it is worth.
ShantanuKumar
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows an opt-in to always using the latest Pip supported by Pex
when upgrading through Pex versions. This is generally desirable for
most Pex consumers.