-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PEP-723 script metadata to --exe
.
#2436
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ecbc802
Add support for PEP-723 to `--exe`.
jsirois 0260cb7
Add tests.
jsirois 94b1e2c
Implement more friendly parse errors.
jsirois 1527753
Merge remote-tracking branch 'upstream/main' into pep-723/wtf
jsirois eca888f
Fix typo.
jsirois e18a7da
Fix un-guarded typing import.
jsirois File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -134,6 +134,9 @@ def __bool__(self): | |
# type: () -> bool | ||
return bool(self.constraints) | ||
|
||
# N.B.: For Python 2.7. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When adding |
||
__nonzero__ = __bool__ | ||
|
||
def __len__(self): | ||
# type: () -> int | ||
return len(self.constraints) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To verify my understanding, this is A) unrelated to the rest of the change and B) only to avoid wasted calculation, since the later call to
pex_builder.set_sh_boot_script
ifsh_boot
is True will override the shebang set here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its unrelated except for the fact that my initial CLI testing used
--sh-boot
and I was getting a spurious "Could not calculate a targeted shebang for: ..." warning. When using--sh-boot
the injected#!/bin/sh
shebang + script header exactly handles a non-unitary set of possible Pythons to use to boot. So the intent was to remove the spurious warning and not to conserve computation.