Stabilize PythonInterpreter __eq__. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior check used the binary's stat which was unstable across variations of mounts atime setting on different machines. If the partition the python binary lived on had atime enabled (default in OSX so an important case), then equality checks would ~always fail for even the same binary. This change switches to using binary real path + its reporter version info which should be all we care about. It's true that the binary might be replaced by a new one of the same version at the same path but compiled with different options though, so we still could do more and instead use binary real path + a content hash of the binary if needed.
wickman
added a commit
that referenced
this pull request
Dec 15, 2014
Stabilize PythonInterpreter __eq__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior check used the binary's stat which was unstable across
variations of mounts atime setting on different machines. If the
partition the python binary lived on had atime enabled (default in
OSX so an important case), then equality checks would ~always fail
for even the same binary.
This change switches to using binary real path + its reporter
version info which should be all we care about. It's true that
the binary might be replaced by a new one of the same version at
the same path but compiled with different options though, so we
still could do more and instead use binary real path + a content
hash of the binary if needed.
https://rbcommons.com/s/twitter/r/1477/