Fix resolution of setup.py project extras.
#739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in pex-tool#582 introduced a bug where requested extras were not preserved for local `setup.py` resolvables. Add failing tests for this and fix. Fixes pex-tool#736
jsirois
commented
Jun 24, 2019
Eric-Arellano
approved these changes
Jun 24, 2019
There was a problem hiding this comment.
Thanks for fixing this and adding tests!
My comments take inspiration from the idea of Atoms of Confusion, that confusing small snippets result in the majority of a project's bugs. Everything looks good now, but the confusing parts down the road may cause issues.
| PROJECT_CONTENT = { | ||
| 'setup.py': dedent(''' | ||
| @contextlib.contextmanager | ||
| def make_project(name='my_project', |
There was a problem hiding this comment.
Good refactor to generalize this 👌
+ Define and check ResolvedDistribution field types. + Restore explicit parameters to pex.testing.make_sdist.
Eric-Arellano
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #582 introduced a bug where requested extras were not
preserved for local
setup.pyresolvables. Add failing tests for thisand fix.
Fixes #736