Do not raise Exception on wait() after terminate or previous wait() #211
Conversation
This matches the same branch of ptyprocess, noexception-on-wait-after-terminate, which allows calling the wait() method multiple times without raising an exception.
Problem: - user installs pexpect==3.2 and ptyprocess==0.4 - change is made to ptyprocess, 0.5 is available - change is made to pexpect, 4.0 is available - user wishes to upgrade, issues "pip install --upgrade pexpect" - the current version of ptyprocess (0.4) remains installed. Solution: - Specify lowerbound '>=0.5' to ensure that existing pexpect installations receive new version of ptyprocess.
|
This looks reasonable. We need to actually get round to releasing ptyprocess. |
|
Do we have to wait until ptyprocess is released to merge? |
|
I'd prefer to keep pexpect master building against released versions of Ptyprocess. As mentioned on #210, it's sort of deliberately inflicted pain to try to ensure a clean distinction between the two packages. I don't think a ptyprocess release is far off, though - we really just need to work out pexpect/ptyprocess#12 and make a decision on pexpect/ptyprocess#10, as far as I know. |
|
That's fine. I'm working out pexpect/ptyprocess#12 now. Bumping into a strange issue with a new test case I introduced where getecho() returns False on FreeBSD and receiving echo of input in read() calls, even though PtyProcess([cmd], echo=True) is used. I'm working it out with TeamCity to run some tests across the board for me, I hope to address it soon. |
|
I reran Travis now that Ptyprocess 0.5 is released, and it is now happy with this. |
Do not raise Exception on wait() after terminate or previous wait()
This matches the same branch of ptyprocess, pexpect/ptyprocess#18 from @reynir,
noexception-on-wait-after-terminate, which allows calling the wait() method multiple times without raising an exception.There is no logical change, only a docstring and adjustments to (otherwise failing) test cases.
(@takluyver: Note that TeamCity comprehends "pairing branch names" across these two repositories and tests them accordingly, but Travis-CI does not (so the test will fail, here). Created issue #210 to address.
Furthermore, described in 4bd7305 it is now necessary to specify
>=0.5requirement of ptyprocess. In this particular case, It isn't terribly harmful, but it is good to start. This too will break the travis-ci build, which would be resolved by release of ptyprocess 0.5 or issue #210)