Download and add openocd to the system path #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 15, 2021 21:11
…s and unpacks the latest OpenOCD release from GitHub.
pfeerick
reviewed
Apr 18, 2021
pfeerick
reviewed
Apr 18, 2021
…resent or not. If it isn't present, this won't hurt, and if it is, we're just setting it up sooner.
So that if you just downloaded OpenOCD, the app will update the current ready status.
pfeerick
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Thank you very much for addressing those issues... it now works perfectly on both Windows and Linux (x64)! :)
I've just added a call to update_control_statuses() when the config dialog has been closed, so that it unlocks the main UI if you just installed OpenOCD and am now merging, making a few more changes and pushing upstream to ElectrO ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is now a button in the configure dialog, cunningly named "Download OpenOCD", which, shockingly, downloads OpenOCD, unpacks it to a directory named
openocd/adjacent to the script itself. It then adds it to the system path (and this is picked up by the validation of the main dialog).Apologies for the size of the change, the stuff relating to downloading from GitHub is pretty self-contained though.
This would resolve issue #2