Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose feature wasm-bindgen from time crate #27

Closed
wants to merge 1 commit into from
Closed

expose feature wasm-bindgen from time crate #27

wants to merge 1 commit into from

Conversation

EAimTY
Copy link
Contributor

@EAimTY EAimTY commented Sep 9, 2022

Current version of the time crate gated the js-sys dependency behind the 'wasm-bindgen' feature

This broke the wasm support of cookie_store:

"panicked at 'time not implemented on this platform', library/std/src/sys/wasm/../unsupported/time.rs:31:9

I think we should expose the wasm-bindgen feature of time to fix this

@jkelleyrtp jkelleyrtp mentioned this pull request Sep 14, 2022
Open
@pfernie
Copy link
Owner

pfernie commented Sep 17, 2022

This is merged; thx for the PR!

@pfernie pfernie closed this Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EAimTY @pfernie