Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install filelock #113

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Install filelock #113

merged 1 commit into from
Dec 17, 2020

Conversation

belldandyxtq
Copy link
Member

This PR adds installation of filelock, which is imported but not listed
in the setup.py.

With current master:

>>> import pfrl
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/tianqi/repository/pfrl/pfrl/__init__.py", line 3, in <module>
    from pfrl import agents  # NOQA
  File "/home/tianqi/repository/pfrl/pfrl/agents/__init__.py", line 1, in <module>
    from pfrl.agents.a2c import A2C  # NOQA
  File "/home/tianqi/repository/pfrl/pfrl/agents/a2c.py", line 7, in <module>
    from pfrl.utils import clip_l2_grad_norm_
  File "/home/tianqi/repository/pfrl/pfrl/utils/__init__.py", line 7, in <module>
    from pfrl.utils.pretrained_models import download_model  # NOQA
  File "/home/tianqi/repository/pfrl/pfrl/utils/pretrained_models.py", line 14, in <module>
    import filelock
ModuleNotFoundError: No module named 'filelock'

This PR adds installation of filelock, which is imported but not listed
in the setup.py.
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muupan muupan merged commit b2b2260 into master Dec 17, 2020
@muupan muupan deleted the install_filelock branch December 17, 2020 04:37
@muupan muupan added this to the v0.2.1 milestone Dec 17, 2020
@muupan muupan added the bug Something isn't working label Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants