Add parameter to generate_exp_id() #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keisukefukuda
changed the title
muupan
reviewed
Dec 17, 2020
keisukefukuda
force-pushed
the
fix-generate-exp-id
branch
from
fad2333
to
b2f46c0
Compare
|
/test |
|
Successfully created a job for commit b2f46c0: |
muupan
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pfrl.experiments.generate_exp_id()generates a experiment ID from serveral sources includingsys.argv.Under certain circumstances, such as distributed or cloud environments, one may want to control generated directory names.
In this PR,
generate_exp_id()takes one more parameterargv, by which you can feed a customargvas a configuration of experiments and control the output directory name.