-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
call evaluation_hooks in Evaluator #122
call evaluation_hooks in Evaluator #122
Conversation
Successfully created a job for commit 073f688: |
Successfully created a job for commit ac05424: |
Successfully created a job for commit 9bb3e19: |
I'd like you to clarify the plan behind this PR.
|
Yes.
I unified arguments of So, remaining tasks are:
|
9bb3e19
to
22b7c57
Compare
Successfully created a job for commit 22b7c57: |
22b7c57
to
43c2fd4
Compare
Successfully created a job for commit 43c2fd4: |
We decided to break backward compatibility for cleaner API. |
call evaluation_hooks in
{Async,}Evaluator
instead oftrain_agent{,_batch,_async}
.This PR is a preparation for unifying
evaluation_hooks
touse_tensorboard
option.(Interactions with Tensorboard are called in
{Async,}Evaluator
.)I also added
support_train_agent{,_batch,_async}
attributes toEvaluationHook
class in order to clarify that which hooks are eligible for each training function (train_agent_with_evaluation, train_agent_batch_with_evaluation, train_agent_async
).NOTE: This PR breaks backward compatibility of
EvaluationHook.__call__
API. It no longer haseval_score
argument. Useeval_stats['mean']
instead (eval_score
is equivalent to it).