Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to mypy>=0.800 #127

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Switch to mypy>=0.800 #127

merged 1 commit into from
Jan 27, 2021

Conversation

muupan
Copy link
Member

@muupan muupan commented Jan 27, 2021 •
edited
Loading

Resolves #126

mypy==0.800 searches child directories even if it has no __init__.py.

examples is kept untouched since it still suffers from "duplicate module" issues.

(pfrl) ➜  pfrl git:(mypy-0800) ✗ mypy examples
examples/slimevolley/train_rainbow.py: error: Duplicate module named 'train_rainbow' (also at 'examples/atari/reproduction/rainbow/train_rainbow.py')
examples/slimevolley/train_rainbow.py: error: Are you missing an __init__.py?
Found 2 errors in 1 file (errors prevented further checking)

@muupan
Copy link
Member Author

muupan commented Jan 27, 2021

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit 4ada630:

@keisuke-nakata keisuke-nakata self-assigned this Jan 27, 2021
keisuke-nakata
keisuke-nakata approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@keisuke-nakata keisuke-nakata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@muupan muupan merged commit 0f77d09 into pfnet:master Jan 27, 2021
@muupan muupan deleted the mypy-0800 branch January 27, 2021 13:36
@muupan muupan added this to the v0.3.0 milestone Jul 7, 2021
@muupan muupan added the testing Changes related to testing/reviewing/CI label Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keisuke-nakata keisuke-nakata keisuke-nakata approved these changes

@prabhatnagarajan prabhatnagarajan Awaiting requested review from prabhatnagarajan

Assignees

@keisuke-nakata keisuke-nakata

Labels
testing Changes related to testing/reviewing/CI
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

CI lint error: Duplicate module named 'basetest_ddpg'
3 participants
@muupan @pfn-ci-bot @keisuke-nakata