-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to DQN and its dependencies #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! A general recommendation I want to discuss is collapsing the from typing ...
imports into a single line (or few lines). Especially for the dqn.py which is already quite sizable.
Since we've done this a few other places I suppose we don't have any style guides against it.
Fixed conflicts.
We agreed that we will introduce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
depends on #16
Adding type hints required some code changes as well. I think these are good changes.
ActionValue.__getitem__
AbstractReplayBuffer.capacity
stop_current_episode
fromAbstractEpisodicReplayBuffer
toAbstractReplayBuffer
.self.target_model
is initialized as None and assigned bysync_target_network
later. After this PR, it cannot be None anymore.