Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy error due to numbers.Number #171

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Fix mypy error due to numbers.Number #171

merged 1 commit into from
Mar 14, 2022

Conversation

muupan
Copy link
Member

@muupan muupan commented Mar 13, 2022

Resolves #170 .

float might be narrower than Number as a type, but I don't think this is a issue here since the _find function is used with float only.

@muupan
Copy link
Member Author

muupan commented Mar 13, 2022

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit a733679:

toslunar
toslunar approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar merged commit a721ddf into pfnet:master Mar 14, 2022
@muupan muupan deleted the fix-ci-error-mypy-prioritized branch March 15, 2022 08:14
@muupan muupan added this to the v0.4.0 milestone Jul 16, 2023
@muupan muupan added the testing Changes related to testing/reviewing/CI label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees
No one assigned
Labels
testing Changes related to testing/reviewing/CI
Projects
None yet
Milestone
v0.4.0
3 participants
@muupan @pfn-ci-bot @toslunar