Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #173 #174

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Fix for issue #173 #174

merged 3 commits into from
Sep 21, 2022

Conversation

jfrancis71
Copy link
Contributor

No description provided.

@jfrancis71
Support gym>=0.24.0; gym==0.24.0 uses py-ale==0.7.5. Environment memb…
e06c489 
…er np_random has changed from numpy RandomState to numpy Generator. See issue pfnet#173
@jfrancis71
Black'ify previous commit
c7cc2df
@github-actions github-actions bot requested a review from muupan June 20, 2022 14:45
@muupan
Copy link
Member

muupan commented Aug 30, 2022

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit c7cc2df:

muupan
muupan requested changes Aug 30, 2022
View reviewed changes
Copy link
Member

@muupan muupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, apologies for my delayed response. The workaround looks good. I think the PR can be merged after the small point I commented is fixed.

pfrl/wrappers/atari_wrappers.py Outdated Show resolved Hide resolved
@muupan
Copy link
Member

muupan commented Sep 21, 2022

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit f09e108:

muupan
muupan approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@muupan muupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI pfn-public-ci/pfrl.lint failed, but it seems irrelevant to the PR.

@muupan muupan merged commit 2ad3d51 into pfnet:master Sep 21, 2022
@muupan muupan mentioned this pull request Sep 21, 2022
Closed
@muupan muupan added this to the v0.4.0 milestone Jul 16, 2023
@muupan muupan added the enhancement New feature or request label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhatnagarajan prabhatnagarajan prabhatnagarajan left review comments

@muupan muupan muupan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jfrancis71 @muupan @pfn-ci-bot @prabhatnagarajan