Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes common write_header function #71

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Makes common write_header function #71

merged 3 commits into from
Oct 7, 2020

Conversation

prabhatnagarajan
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan commented Sep 9, 2020 •
edited
Loading

AsyncEvaluator and Evaluator both use common code and functionality for generating a header in the scores.txt file. This PR unifies them.

  • Run an async agent with an evaluation and check it doesn't break
  • Run a normal agent with an evaluation and check it doesn't break
  • Run black

@prabhatnagarajan prabhatnagarajan marked this pull request as ready for review September 9, 2020 08:52
@prabhatnagarajan
Copy link
Contributor Author

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit bebe8b0:

ummavi
ummavi approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@ummavi ummavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ummavi ummavi merged commit e485a30 into pfnet:master Oct 7, 2020
@prabhatnagarajan prabhatnagarajan deleted the write_header branch October 7, 2020 03:31
@muupan muupan added the enhancement New feature or request label Dec 11, 2020
@muupan muupan added this to the v0.2.0 milestone Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ummavi ummavi ummavi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@prabhatnagarajan @pfn-ci-bot @ummavi @muupan