Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach greedy_actions before calling cpu() #81

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Conversation

muupan
Copy link
Member

@muupan muupan commented Oct 14, 2020

Resolves #40

@github-actions github-actions bot requested a review from marioyc October 14, 2020 02:15
@marioyc
Copy link
Contributor

marioyc commented Oct 14, 2020

Would the same error happen here for StateQFunctionActor?

@muupan
Copy link
Member Author

muupan commented Oct 14, 2020

Good point. Will fix StateQFunctionActor as well.

@muupan
Copy link
Member Author

muupan commented Oct 14, 2020

Fixed. Now there is no "greedy_actions.cpu()" in the repository.

Copy link
Contributor

@marioyc marioyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muupan muupan merged commit 2217e2c into master Oct 14, 2020
@muupan muupan deleted the detach-greedy-actions branch October 14, 2020 03:22
@muupan muupan added this to the v0.2.0 milestone Dec 14, 2020
@muupan muupan added the bug Something isn't working label Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using no_grad () and lazy_property
2 participants