Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt isort to format import sentences #82

Merged
merged 4 commits into from
Nov 4, 2020
Merged

Adopt isort to format import sentences #82

merged 4 commits into from
Nov 4, 2020

Conversation

muupan
Copy link
Member

@muupan muupan commented Oct 14, 2020 •
edited
Loading

Resolves #53

@github-actions github-actions bot requested a review from ummavi October 14, 2020 02:59
@muupan muupan changed the title Adopt isort to format import sentences [WIP] Adopt isort to format import sentences Oct 14, 2020
@muupan
Copy link
Member Author

muupan commented Oct 14, 2020

It seems something went wrong. Will fix errors in other CI.

@muupan muupan changed the title [WIP] Adopt isort to format import sentences Adopt isort to format import sentences Oct 14, 2020
@muupan
Copy link
Member Author

muupan commented Oct 14, 2020

The errors were fixed.

ummavi
ummavi approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@ummavi ummavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ummavi ummavi merged commit 9be4726 into master Nov 4, 2020
@ummavi ummavi deleted the isort branch November 4, 2020 02:14
@muupan muupan added this to the v0.2.0 milestone Dec 14, 2020
@muupan muupan added the testing Changes related to testing/reviewing/CI label Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ummavi ummavi ummavi approved these changes

Assignees
No one assigned
Labels
testing Changes related to testing/reviewing/CI
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

Apply isort in CI
2 participants
@muupan @ummavi