Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pysen-test action #19

Merged
merged 1 commit into from
May 14, 2022
Merged

Add pysen-test action #19

merged 1 commit into from
May 14, 2022

Conversation

bonprosoft
Copy link
Collaborator

I created pysen-test action.
The action builds the Dockerfile on each CI job and runs tox on the built image.

Initially I used the docker image hosted on quay.io.
But actually it would be problematic for some PRs like #18 to update the docker image.

Hakuyume
Hakuyume approved these changes May 14, 2022
View reviewed changes
Copy link
Member

@Hakuyume Hakuyume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bonprosoft bonprosoft added the chore Refactoring or non bug fixes label May 14, 2022
@bonprosoft bonprosoft merged commit 3bf7ba3 into main May 14, 2022
@bonprosoft bonprosoft deleted the pysen-test-action branch May 14, 2022 15:24
@bonprosoft bonprosoft mentioned this pull request May 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hakuyume Hakuyume Hakuyume approved these changes

@himkt himkt Awaiting requested review from himkt

@sergeant-wizard sergeant-wizard Awaiting requested review from sergeant-wizard

Assignees
No one assigned
Labels
chore Refactoring or non bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bonprosoft @Hakuyume