Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable new PyTorch autocast #649

Merged
merged 11 commits into from
Apr 6, 2023
Merged

Enable new PyTorch autocast #649

merged 11 commits into from
Apr 6, 2023

Conversation

emcastillo
Copy link
Contributor

No description provided.

@emcastillo
Copy link
Contributor Author

/test

1 similar comment
@emcastillo
Copy link
Contributor Author

/test

@emcastillo emcastillo force-pushed the new-autocast branch 2 times, most recently from 19b9a3e to 1173eba Compare March 6, 2023 09:03
@emcastillo emcastillo changed the title [WIP] Enable new PyTorch autocast Enable new PyTorch autocast Mar 6, 2023
emcastillo
emcastillo commented Mar 6, 2023
View reviewed changes
pytorch_pfn_extras/utils/__init__.py Outdated
@@ -1,2 +1 @@
from pytorch_pfn_extras.utils import checkpoint # NOQA
from pytorch_pfn_extras.utils import comparer # NOQA
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid circular deps when importing utils module from logic or runtime

@emcastillo
Copy link
Contributor Author

/test

@emcastillo
Copy link
Contributor Author

/test

@kmaehashi kmaehashi self-assigned this Mar 7, 2023
@kmaehashi kmaehashi added the cat:enhancement New feature or request label Mar 7, 2023
@emcastillo
Copy link
Contributor Author

/test

kmaehashi
kmaehashi reviewed Mar 7, 2023
View reviewed changes
Copy link
Member

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Reviewed the API surface.

pytorch_pfn_extras/handler/__init__.py Outdated Show resolved Hide resolved
pytorch_pfn_extras/handler/_logic.py Outdated Show resolved Hide resolved
@emcastillo
Copy link
Contributor Author

/test

@emcastillo
Copy link
Contributor Author

PTAL!

kmaehashi
kmaehashi reviewed Apr 3, 2023
View reviewed changes
pytorch_pfn_extras/runtime/_autocast.py Outdated Show resolved Hide resolved
pytorch_pfn_extras/runtime/_autocast.py Outdated Show resolved Hide resolved
pytorch_pfn_extras/handler/_logic.py Outdated Show resolved Hide resolved
pytorch_pfn_extras/handler/_logic.py Outdated Show resolved Hide resolved
pytorch_pfn_extras/runtime/_autocast.py Outdated Show resolved Hide resolved
pytorch_pfn_extras/runtime/_autocast.py Outdated Show resolved Hide resolved
@emcastillo
Copy link
Contributor Author

PTAL!!

Emilio Castillo added 2 commits April 3, 2023 07:13
kmaehashi
kmaehashi reviewed Apr 3, 2023
View reviewed changes
Copy link
Member

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe like this?

pytorch_pfn_extras/handler/_logic.py Outdated Show resolved Hide resolved
pytorch_pfn_extras/handler/_logic.py Outdated Show resolved Hide resolved
pytorch_pfn_extras/runtime/_autocast.py Show resolved Hide resolved
pytorch_pfn_extras/runtime/_autocast.py Outdated Show resolved Hide resolved
pytorch_pfn_extras/handler/_logic.py Outdated Show resolved Hide resolved
pytorch_pfn_extras/runtime/_autocast.py Outdated Show resolved Hide resolved
pytorch_pfn_extras/runtime/_autocast.py Outdated Show resolved Hide resolved
emcastillo and others added 2 commits April 4, 2023 10:56
@kmaehashi
Apply suggestions from code review
e490ab5 
Co-authored-by: Kenichi Maehashi <939877+kmaehashi@users.noreply.github.com>
fix
cfa84ca
@emcastillo
Copy link
Contributor Author

/test

@emcastillo
Copy link
Contributor Author

/test

@kmaehashi kmaehashi added this to the v0.6.6 milestone Apr 6, 2023
kmaehashi
kmaehashi approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@kmaehashi kmaehashi merged commit 23f18ab into pfnet:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaehashi kmaehashi kmaehashi approved these changes

@asi1024 asi1024 Awaiting requested review from asi1024 asi1024 is a code owner

Assignees

@kmaehashi kmaehashi

Labels
cat:enhancement New feature or request
Projects
None yet
Milestone
v0.6.6
Development

Successfully merging this pull request may close these issues.
2 participants
@emcastillo @kmaehashi