Trigger for using user custom functions #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linshokaku
requested review from
asi1024,
emcastillo and
kmaehashi
as code owners
emcastillo
reviewed
Nov 21, 2023
| if not self._interval_trigger(manager): | ||
| return False | ||
|
|
||
| return self._fn(*self._args, **self._kwargs) |
There was a problem hiding this comment.
I wonder if it would be good to add something like the current iteration/epoch as positional arguments
There was a problem hiding this comment.
If iteration or epoch information is needed, it is assumed that users will implement a function that explicitly takes manager as an argument, and pass manager to args/kwargs to achieve this.
emcastillo
approved these changes
Nov 28, 2023
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #774