Skip to content
This repository has been archived by the owner on Jan 22, 2018. It is now read-only.

arpwatch quotes only go around email address #3584 #643

Merged
merged 4 commits into from
Apr 10, 2014
Merged

arpwatch quotes only go around email address #3584 #643

merged 4 commits into from
Apr 10, 2014

Conversation

phil-davis
Copy link

This was updated recently by fc65960 but it just looks like the wrong place to add the quotes.
Please test before committing.

This was updated recently by fc65960 but it just looks like the wrong place to add the quotes.
Please test before committing.
@phil-davis
Copy link
Author

Testing results are in https://redmine.pfsense.org/issues/3584
Seems a good thing.

@phil-davis
Copy link
Author

Another user reporting this issue on the forum at https://forum.pfsense.org/index.php?topic=74918.0
So it would be good to commit this change.

@bryanparadis
Copy link
Contributor

#614

Maybe my pull will get merged one day. 👎

@phil-davis
Copy link
Author

To be fair, they are all rather busy building and checking 2.1.2 release. But since loads of people are likely to do upgrades shortly after the release, and upgrades also do package reinstalls, it is good to get any little known package bugs committed to save the subsequent stream of forum posts that think the package bugs are actually the fault of 2.1.n-RELEASE.
Probably worth bumping the arpwatch version for this also, so it can be easily seen if people have the fixed one. I'll add that to the pull request now.

@phil-davis
Copy link
Author

arpwatch version bump done.

@bryanparadis
Copy link
Contributor

This fix is included in my pull as well
Le 9 avr. 2014 22:43, "Phil Davis" notifications@github.com a écrit :

arpwatch version bump done.

Reply to this email directly or view it on GitHubhttps://github.com//pull/643#issuecomment-40037895
.

@phil-davis
Copy link
Author

Now I understand. I hadn't even looked that far back to see that this bug already has a fix waiting to be implemented! Anyway, it would be good if something gets committed.

cbuechler pushed a commit that referenced this pull request Apr 10, 2014
arpwatch quotes only go around email address #3584
@cbuechler cbuechler merged commit 0e80d54 into pfsense:master Apr 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants