Fix #7299 Old rules with ICMP types #3571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #3572 for a more general fix. |
|
@rbgarga @jim-p Grischa Zengel has commented on the issue, that after an upgrade a rule like this causes "error loading the rules" and so the rule set is not loaded at all. So it is a big issue for those that come across it. |
|
I merged #3572 - Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal patch to just make sure that when there are ICMP types, the 'ipprotocol' gets set to 'inet' if it is not specified in the rule.
It fixes the reported behavior that I managed to reproduce in 2.3.3 - so the patch needs to be back-ported there.