OpenVPN w/ IPv6 fails to set ifconfig-ipv6 value in conf #2991 #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuechler
pushed a commit
that referenced
this pull request
May 14, 2013
OpenVPN w/ IPv6 fails to set ifconfig-ipv6 value in conf #2991
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Net_IPv6::compress returns "" when the IPv6 address is already compressed!!! That is a bug in Net_IPv6, but might be more difficult to correct right now. The way to make sure things are OK is to call uncompress first, to always make sure an uncompressed IPv6 addres is passed to compress. Note: uncompress works fine if the address is already uncompressed - it returns what it was given.
I will search later for other uses of Net_IPv6::compress in pfSense code, as they will all have the potential for this kind of error.
$ipv6 = "fe80::1";
$ipv6_1 = Net_IPv6::compress($ipv6);
var_dump($ipv6_1);
string(0) ""
$ipv6_1 = Net_IPv6::compress(Net_IPv6::uncompress($ipv6));
var_dump($ipv6_1);
string(7) "fe80::1"