Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arp_table_static_entry option pfsense_dhcp_static.py module #111

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Add arp_table_static_entry option pfsense_dhcp_static.py module #111

merged 6 commits into from
Jan 11, 2024

Conversation

cmarodrigues
Copy link
Contributor

Hello,

This PR will add ARP Table Static Entry option to pfsense_dhcp_static.py module

@cmarodrigues cmarodrigues mentioned this pull request Jan 9, 2024
Closed
@opoplawski
Copy link
Contributor

Thanks. It needed a little tweaking to be able to remove arp_table_static_entry when not set. I'm working on adding some tests as well.

In the future, I would recommend creating a branch for changes.

@opoplawski opoplawski added the enhancement New feature or request label Jan 11, 2024
@opoplawski opoplawski added this to the 0.6.1 milestone Jan 11, 2024
@opoplawski opoplawski linked an issue Jan 11, 2024 that may be closed by this pull request
Module pfsense_dhcp_static - ARP Static Entry #109
Closed
@opoplawski opoplawski merged commit 2e4ca77 into pfsensible:master Jan 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.

Module pfsense_dhcp_static - ARP Static Entry
2 participants
@cmarodrigues @opoplawski