Enabled keydown handler on iFrame preview #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted keydown event binding to a separate function that now expects a jQuery element. Pointed existing keydown calls at this new function to preserve the method signature of existing callers. Added new function that handles registering keydown event handlers on the iFrame preview. This also points to the common function to actually register the event handler.
zamcnema
added a commit
that referenced
this pull request
Feb 24, 2016
Enabled keydown handler on iFrame preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted keydown event binding to a separate function that now
expects a jQuery element. Pointed existing keydown calls at this
new function to preserve the method signature of existing callers.
Added new function that handles registering keydown event handlers
on the iFrame preview. This also points to the common function to
actually register the event handler.