Drop support for old Postgres versions #343
Conversation
msakrejda
force-pushed
the
drop-support-for-old-postgres-versions
branch
from
23c05ea
to
fcdc59c
Compare
There was a problem hiding this comment.
👍 Looks good, with two minor comments.
Overall, I think dropping 9.5 and older support is clearly the right choice - those versions are long gone.
9.6 and 10 there are still some late upgraders, so doesn't hurt to keep them around for a bit longer and then drop them when we either have a good reason, or more time has passed.
state/postgres_version.go
Outdated
| // MinRequiredPostgresVersion - We require PostgreSQL 9.3 or newer | ||
| MinRequiredPostgresVersion = PostgresVersion93 | ||
| // MinRequiredPostgresVersion - We require PostgreSQL 9.6 or newer | ||
| MinRequiredPostgresVersion = PostgresVersion96 |
There was a problem hiding this comment.
There is a hard-coded "9.3 or newer is required." message on the top of input/full.go that also needs to be updated.
There was a problem hiding this comment.
Re-using this thread - On another note, I just realized we should probably raise this to Postgres 10 being the minimum - because that was the first version to use $n style replacement characters in pg_stat_statements.
See #383, which will effectively make Postgres 9.6 not work with the collector (since we fail to parse / normalize the statements containing "?").
There was a problem hiding this comment.
Makes sense. I'll update once #339 lands.
|
I pushed an update cleaning up other mentions of older versions. The last commit gets rid of support for parsing pre-9.6 log lines (at least those that were documented as such). Let me know if we should be more conservative and I can just drop that commit, but I checked 9.6 xlog.c and vacuumlazy.c, and those parts of the messages are always present. |
In 06daccd, we dropped CI testing for Postgres versions older than 9.6 (which itself has been EOL for over a year). Drop support in code to allow us to simplify some logic. Users who need support for older Postgres releases can use an older collector for the time being.
msakrejda
force-pushed
the
drop-support-for-old-postgres-versions
branch
from
3641b0c
to
6ea8076
Compare
This was accidentally mangled a bit in #343.
This was accidentally mangled a bit in #343.
In 06daccd, we dropped CI testing for
Postgres versions older than than 9.6 (which itself has been EOL for over a
year).
Drop support in code to allow us to simplify some logic. Users who
need support for older Postgres releases can use an older collector
for the time being.