Added parser.Split() #97
Conversation
francoislarochelle
force-pushed
the
add-split
branch
from
faf0396
to
210aac6
Compare
|
Hey @lfittl ! Would you mind taking a look at this? This would enable us using this lib in some projects. Thanks a lot! |
There was a problem hiding this comment.
@francoislarochelle Thanks for the contribution!
Two small comments, if these are addressed this should be good to merge.
I also do wonder if we should add SplitWithScanner at the same time, as @SKalt previously worked on in #52 - I believe the mechanism you used for SplitWithParser should be almost identical for what we'd need to do for SplitWithScanner.
|
Hello @lfittl ! Sorry for the delay but I have pushed some changes based on your suggestions. I have also added |
Excellent, thank you for making those changes! |
I'd like to have access to the Split method in my Go projects.
Added invocation of parser.Split() and build an array of slices from its results.