Build musllinux wheels in CI #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMino
commented
Apr 14, 2023
| if: ${{ matrix.platform == 'manylinux2014_aarch64' }} | ||
| if: | | ||
| matrix.platform == 'manylinux2014_aarch64' || | ||
| matrix.platfrom == 'musllinux_1_1_aarch64' |
There was a problem hiding this comment.
I'm a bit unsure about this. Why do we need Qemu for aarch64? I thought auditwheel can handle arch without emulation?
There was a problem hiding this comment.
Maybe it can now but it couldn't in 2019 or 2020? I doubt that I had a deep understanding of what I was doing when I put this together.
There was a problem hiding this comment.
I'll try and check, removing this would speed up CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #135