Configure isort to be compatible with black #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the main inconsistencies with black is the multi-line output, so black will try to write: from module import ( x, y, z, ) But isort will try to write: from module import x, y, z This makes it impossible to pass --check with both tools. I've also included a few other changes to the isort configuration that were mostly stolen from the attrs project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the main inconsistencies with black is the multi-line output, so black will try to write:
But isort will try to write:
This makes it impossible to pass
--checkwith both tools.I've also included a few other changes to the isort configuration that were mostly stolen from the attrs project.