Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self-closing title tag makes rest of page blank #28

Closed
pgaskin opened this issue May 2, 2018 · 0 comments
Closed

Self-closing title tag makes rest of page blank #28

pgaskin opened this issue May 2, 2018 · 0 comments
Assignees
@pgaskin
Labels
bug

Comments

@pgaskin
Copy link
Owner

pgaskin commented May 2, 2018

I've had many emails about this, even though self-closing title tags are technically invalid. This issue is similar to readium/readium-sdk#81.

I've decided to fix this due to the number of complaints.
@pgaskin pgaskin added the bug label May 2, 2018
@pgaskin pgaskin self-assigned this May 2, 2018
@pgaskin pgaskin closed this as completed in c7f6b09 May 2, 2018
pgaskin added a commit to pgaskin/net that referenced this issue Jan 12, 2020
@pgaskin
html: Added new ParseOptionLenientSelfClosing option
6b2e8e4 
This option slightly relaxes parsing rules about which elements can
be self-closing to fix common issues with XHTML in EPUBs generated
by XML tooling.

See pgaskin/kepubify#45 and pgaskin/kepubify#28 for a few examples.
pgaskin added a commit to pgaskin/net that referenced this issue Jan 12, 2020
@pgaskin
html: Added new ParseOptionLenientSelfClosing option [MOD]
0c8bbdb 
This option slightly relaxes parsing rules about which elements can
be self-closing to fix common issues with XHTML in EPUBs generated
by XML tooling.

See pgaskin/kepubify#45 and pgaskin/kepubify#28 for a few examples.
pgaskin added a commit to pgaskin/net that referenced this issue Jan 12, 2020
@pgaskin
html: Added new ParseOptionLenientSelfClosing option [MOD]
bc324ea 
This option slightly relaxes parsing rules about which elements can
be self-closing to fix common issues with XHTML in EPUBs generated
by XML tooling.

See pgaskin/kepubify#45 and pgaskin/kepubify#28 for a few examples.
pgaskin added a commit to pgaskin/net that referenced this issue Jan 12, 2020
@pgaskin
html: Added new ParseOptionLenientSelfClosing option [MOD]
85aecc8 
This option slightly relaxes parsing rules about which elements can
be self-closing to fix common issues with XHTML in EPUBs generated
by XML tooling.

See pgaskin/kepubify#45 and pgaskin/kepubify#28 for a few examples.
pgaskin added a commit to pgaskin/net that referenced this issue Jan 12, 2020
@pgaskin
html: add ParseOptionLenientSelfClosing option [mod]
bd56673 
This option slightly relaxes parsing rules about which elements can
be self-closing to fix common issues with XHTML in EPUBs generated
by XML tooling.

See pgaskin/kepubify#45 and pgaskin/kepubify#28 for a few examples.
@pgaskin pgaskin mentioned this issue Jan 12, 2020
Closed
pgaskin added a commit that referenced this issue Jan 14, 2020
@pgaskin
Completely rewrote kepub code
1282954 
- Improved robustness
  - More is implemented directly in the HTML parser and renderer (see my fork of x/net/html)
  - Better support for XHTML and HTML5 (rather than using a bunch of workarounds)
  - No more regexps for modifying HTML
- Better smart punctuation
  - More punctuation supported
  - More robust (won't apply to everything unconditionally)
  - Now off by default
- Faster and more efficient (15-30% faster, 50-70% less memory)
  - Less memory allocations and copies due to use of readers and writers rather than storing rhe entire file in memory multiple times
  - Stack-based span adding algorithm (rather than recursive, which has more runtime and memory overhead)
  - Use byte arrays or runes rather than strings where possible
  - Better parallel processing of content files
  - Eliminated memory, goroutine, and file descriptor leaks
- Cleaner and better code
  - Easier to extend
  - More stable API
  - More complete unit tests
- More accurate sentence splitting and segment numbering (checked against 3 recent free books)
  - Better match Kobo's behavior by preserving, but not wrapping (in a koboSpan) TextNodes with only whitespace. Previous versions of kepubify used to collapse it to a single space, which still works, but is less efficient to do and is slightly different than what Kobo does (although it results in the same thing during rendering).
  - Fixed some edge cases where the segment counter could be incorrectly incremented.
  - Also increment paragraph counter for tables (this case was missing before).
  - Don't increment paragraph counter if spans were added (i.e. an empty or only whitespace paragraph element) (this case was missing before).
- Smaller binary size
- Also run tests on Windows

closes #47, fixes #45, fixes #35
better fix for #36, #29, #28, #26, #21, #14, #10, #5, and #2
pgaskin added a commit that referenced this issue Jun 11, 2021
@pgaskin
html: add ParseOptionLenientSelfClosing option
d1df194 
This option slightly relaxes parsing rules about which elements can
be self-closing to fix common issues with XHTML in EPUBs generated
by XML tooling.

See #45 and #28 for a few examples.
pgaskin added a commit that referenced this issue Jun 11, 2021
@pgaskin
html: add ParseOptionLenientSelfClosing option
ec4c3e9 
This option slightly relaxes parsing rules about which elements can
be self-closing to fix common issues with XHTML in EPUBs generated
by XML tooling.

See #45 and #28 for a few examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgaskin pgaskin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pgaskin