Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angles: set pics/code in angle #1069

Merged
merged 1 commit into from
Nov 2, 2021
Merged

angles: set pics/code in angle #1069

merged 1 commit into from
Nov 2, 2021

Conversation

hmenke
Copy link
Member

@hmenke hmenke commented Nov 2, 2021

Motivation for this change

Fixes #1068

When angle (or right angle) pics appear within another pic, they may
cause a stack overflow because they don't reset /tikz/pics/code.

Checklist

Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead:

When angle (or right angle) pics appear within another pic, they may
cause a stack overflow because they don't reset /tikz/pics/code.

Signed-off-by: Henri Menke <henri@henrimenke.de>
@hmenke hmenke requested a review from muzimuzhi November 2, 2021 16:50
@hmenke hmenke added the pic label Nov 2, 2021
@muzimuzhi
Copy link
Member

muzimuzhi commented Nov 2, 2021

Surprised that angle pic type(s), introduced in 068ae78, only makes use of background/foreground code. It seemed to suggest uses like \draw[pics/code=...] ... pic {angle}; but I can't come up with a reasonable use case for now.

@muzimuzhi muzimuzhi merged commit 80c4ebf into pgf-tikz:master Nov 2, 2021
@hmenke hmenke deleted the angles branch November 3, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Error when using angle pic in another pic
2 participants