Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skips the part of double-slash inline comments after the first slash #58

Closed
sompylasar opened this issue Dec 19, 2016 · 3 comments
Closed

Comments

@sompylasar
Copy link
Contributor

Example:

// HACK(@sompylasar): Nice underline -- @see https://medium.com/designing-medium/crafting-link-underlines-on-medium-7c03a9274f9

Parsed text:

"Nice underline -- @see https:"
@sompylasar sompylasar changed the title Skips URLs in double-slash inline comments because a URL starts with a double slash as well Skips URLs in double-slash inline comments because a URL contains a slash as well Dec 19, 2016
@sompylasar
Copy link
Contributor Author

Example:

// HACK(@sompylasar): Nice underline -- @see https:medium.com/designing-medium/crafting-link-underlines-on-medium-7c03a9274f9

Parsed text:

"Nice underline -- @see https:medium.com"

@sompylasar sompylasar changed the title Skips URLs in double-slash inline comments because a URL contains a slash as well Skips the part of double-slash inline comments after the first slash Dec 19, 2016
@sompylasar
Copy link
Contributor Author

Example:

// HACK(@sompylasar): Sort the chunks by name, the numeric prefixes go first, see `webpack/configFactory`.

Parsed text:

"Sort the chunks by name, the numeric prefixes go first, see `webpack"

Expected text:

"Sort the chunks by name, the numeric prefixes go first, see `webpack/configFactory`."

@sompylasar
Copy link
Contributor Author

Caused by the support of "trailing references":

# FIXME: Make it better /tregusti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant