New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove support for postgresql < 8.2 #661

Merged
merged 1 commit into from Nov 14, 2016

Conversation

Projects
None yet
3 participants
@jorsol
Contributor

jorsol commented Oct 8, 2016

Refactor to support PostgreSQL 8.2+.
Since unit test are not designed to run under pg8.2 (yet) the driver "should" work under 8.2 but I can't guarantee it.

If there are community members that can help the certification with pg8.2 and/or pg8.3 or another variant that is based on those versions, it would be great.

@codecov-io

This comment has been minimized.

codecov-io commented Oct 8, 2016

Current coverage is 63.20% (diff: 51.15%)

Merging #661 into master will increase coverage by 1.21%

@@             master       #661   diff @@
==========================================
  Files           150        150          
  Lines         15145      14694   -451   
  Methods           0          0          
  Messages          0          0          
  Branches       3045       2906   -139   
==========================================
- Hits           9388       9287   -101   
+ Misses         4510       4216   -294   
+ Partials       1247       1191    -56   

Powered by Codecov. Last update b4604cd...22aa490

@jorsol jorsol force-pushed the jorsol:remove-server-82 branch from c3fb32b to e893b83 Oct 18, 2016

@vlsi vlsi force-pushed the pgjdbc:master branch 2 times, most recently from c8cebf6 to f52bf7f Oct 29, 2016

@jorsol jorsol force-pushed the jorsol:remove-server-82 branch from e893b83 to 5e3877f Oct 30, 2016

@vlsi vlsi added this to the 9.4.1213 milestone Nov 12, 2016

@vlsi vlsi self-assigned this Nov 12, 2016

@vlsi

This comment has been minimized.

Member

vlsi commented Nov 12, 2016

This seems to include too much reformatting that does not relate with "drop <8.2" subject. Please avoid doing reformat for little reason.

@vlsi

This comment has been minimized.

Member

vlsi commented Nov 12, 2016

E.g.

PgDatabaseMetaData

   public String getNumericFunctions() throws SQLException {
-    return EscapedFunctions.ABS + ',' + EscapedFunctions.ACOS + ',' + EscapedFunctions.ASIN + ','
-        + EscapedFunctions.ATAN + ',' + EscapedFunctions.ATAN2 + ',' + EscapedFunctions.CEILING
-        + ',' + EscapedFunctions.COS + ',' + EscapedFunctions.COT + ',' + EscapedFunctions.DEGREES
-        + ',' + EscapedFunctions.EXP + ',' + EscapedFunctions.FLOOR + ',' + EscapedFunctions.LOG
-        + ',' + EscapedFunctions.LOG10 + ',' + EscapedFunctions.MOD + ',' + EscapedFunctions.PI
-        + ',' + EscapedFunctions.POWER + ',' + EscapedFunctions.RADIANS + ','
-        + EscapedFunctions.ROUND + ',' + EscapedFunctions.SIGN + ',' + EscapedFunctions.SIN + ','
-        + EscapedFunctions.SQRT + ',' + EscapedFunctions.TAN + ',' + EscapedFunctions.TRUNCATE;
-
+    return EscapedFunctions.ABS + ',' + EscapedFunctions.ACOS + ','
+           + EscapedFunctions.ASIN + ',' + EscapedFunctions.ATAN + ','
+           + EscapedFunctions.ATAN2 + ',' + EscapedFunctions.CEILING + ','
+           + EscapedFunctions.COS + ',' + EscapedFunctions.COT + ','
+           + EscapedFunctions.DEGREES + ',' + EscapedFunctions.EXP + ','
+           + EscapedFunctions.FLOOR + ',' + EscapedFunctions.LOG + ','
+           + EscapedFunctions.LOG10 + ',' + EscapedFunctions.MOD + ','
+           + EscapedFunctions.PI + ',' + EscapedFunctions.POWER + ','
+           + EscapedFunctions.RADIANS + ',' + EscapedFunctions.ROUND + ','
+           + EscapedFunctions.SIGN + ',' + EscapedFunctions.SIN + ','
+           + EscapedFunctions.SQRT + ',' + EscapedFunctions.TAN + ','
+           + EscapedFunctions.TRUNCATE;
   }
@vlsi

This comment has been minimized.

Member

vlsi commented Nov 12, 2016

@jorsol , I'll test #661 and #659 together in the #659

@jorsol jorsol force-pushed the jorsol:remove-server-82 branch 3 times, most recently from 4bae0cb to b6d021e Nov 13, 2016

@jorsol jorsol force-pushed the jorsol:remove-server-82 branch from b6d021e to 22aa490 Nov 13, 2016

@jorsol

This comment has been minimized.

Contributor

jorsol commented Nov 13, 2016

@vlsi I have removed some formatting to facilitate review, you can test 22aa490 on #659

@vlsi vlsi merged commit 14e64be into pgjdbc:master Nov 14, 2016

2 checks passed

codecov/project 63.20% (+1.21%) compared to b4604cd
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vlsi

This comment has been minimized.

Member

vlsi commented Nov 14, 2016

Great. Thank you.
The leftover changes should probably be considered for inclusion as well.

@jorsol jorsol deleted the jorsol:remove-server-82 branch Dec 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment