Added test case for checking the return code when an xid does not exist. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| xaRes.rollback(xid); | ||
| try | ||
| { | ||
| xaRes.rollback(xid); |
There was a problem hiding this comment.
hi jeremy, you need a fail("Rollback was successful") here
There was a problem hiding this comment.
Jeremy,
Is this ready to be merged or do you have to add the above from Tom?
There was a problem hiding this comment.
Hi Dave, Tom is right. I will add it now and push the change.
There was a problem hiding this comment.
Dave, the change recommended by Tom has been pushed.
davecramer
pushed a commit
that referenced
this pull request
Aug 19, 2013
Added test case for checking the return code when an xid does not exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates how the current driver does not report back an error code during transaction recovery process. Calling recover on the same Xid should return an error indicating the xid was not found. Instead it is reporting a general error about the resource manager.
Regards,
Jeremy