Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added containerization folder structure + postgres persistent storage… #82

Merged
merged 2 commits into from
May 29, 2018
Merged

Conversation

sfarosu
Copy link
Contributor

@sfarosu sfarosu commented May 20, 2018

Hello, it's me again :)

As you will see, this pull will bring the "containerization" folder where i propose we keep all docker related stuff like "passwordpusher-ephemeral", "passwordpusher-postgres" and later "passwordpusher-openshift".

New stuff:

  • directory structure
  • README.md file under containerization/ (can be improved)
  • slimed down the images with about 100mb
  • passwordpusher-ephemeral has it's own folder/category and it's the one using just sqlite3
  • passwordpusher-postgres is using docker-compose to launch both password pusher and postgres in separate containers and saves data on host machine in /var/lib/postgresql/data

On your side you should do the following changes:

  • accept the pull so your repo has the containerization folder
  • build the passwordpusher-ephemeral image on your machine and push it to your docker.io account
  • update the /containerization/README.md file lines 12 and 13 with the correct images
  • delete the Dockerfile from the root of the repo as it's replaced by new dir structure
  • in the file /containerization/passwordpusher-postgres/Dockerfile after the containerization folder exists in your repo, you should delete line 15 wich refers to my repo and uncomment line 14
  • build the passwordpusher-postgres image on your machine and push it to your docker.io account
  • in the file /containerization/passwordpusher-postgres/docker-compose.yaml update line 16 with your docker.io image

I know it's alot of stuff, but this way everything will point to the project not to my repo/docker.io.

@pglombardo
Copy link
Owner

Hey @sfarosu this is great. Let me get some free time and dive into this soon. thanks!

@pglombardo
Copy link
Owner

Looks great @sfarosu. I've built and pushed the images. A bit more testing and I'll merge soon.

If you're up for it, I can add you as collaborator on those images... Let me know and I'll add you.

https://hub.docker.com/u/pglombardo/

@pglombardo pglombardo merged commit 826a8b4 into pglombardo:master May 29, 2018
@pglombardo
Copy link
Owner

@sfarosu you rock. Thanks for adding this support. Merged and my PR with the touch-ups is in #85. Thanks again!

@sfarosu
Copy link
Contributor Author

sfarosu commented May 29, 2018

Don't mention it, i love your app so it deserves the attention :)

Ok, i got the ball again with :

  • create documentation for openshift and maybe instead of using an image we can build directly in openshift using a "buildconfig"..so we don't refer to an external image anymore
  • i need to build myself a small Kubernetes cluster and validate everything on this platform too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants