Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for 'readable' event. #146

Closed
tlivings opened this issue Feb 7, 2014 · 11 comments
Closed

No support for 'readable' event. #146

tlivings opened this issue Feb 7, 2014 · 11 comments

Comments

@tlivings
Copy link

tlivings commented Feb 7, 2014

If an http client parses data on readable event rather than data, nock fails.

@jbergknoff
Copy link

Are there any plans to add support for this?

@ierceg
Copy link
Contributor

ierceg commented May 16, 2014

If you provide a unit test that fails with this issue, I would try to fix it.

@ierceg
Copy link
Contributor

ierceg commented May 16, 2014

I see you gave an example on the other thread. I'll check it out when I get some time.

@jbergknoff
Copy link

Great. Thank you very much.

@ierceg
Copy link
Contributor

ierceg commented May 19, 2014

@jbergknoff I've just created PR #175 with a fix for this. If you want to test it on your end before it gets merged into master you can find it in fix-146 branch.

@jbergknoff
Copy link

Seems like your change fixes my issue. Thanks, @ierceg.

@ierceg
Copy link
Contributor

ierceg commented May 19, 2014

Great, tnx for letting me know.

On Mon, May 19, 2014 at 7:01 PM, jbergknoff notifications@github.comwrote:

Seems like your change fixes my issue. Thanks, @ierceghttps://github.com/ierceg
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/146#issuecomment-43568961
.

@jbergknoff
Copy link

I may have spoken too soon -- still seeing issues elsewhere in my test suite. They may have a different cause. I will update when I understand better.

@ierceg
Copy link
Contributor

ierceg commented May 19, 2014

Ok, tnx.

@pgte pgte closed this as completed in #175 May 20, 2014
@tlivings
Copy link
Author

Opened a new issue regarding this: #193

@lock
Copy link

lock bot commented Sep 14, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants