-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mm.isMatch(path.join(folder.replace(srcFolder, ''), file) is not working properly #43
Labels
bug
Something isn't working
Comments
diegoazh
added a commit
to diegoazh/gmap-vue
that referenced
this issue
Aug 1, 2021
vuepress-jsdoc has an issue with minimatch and picomatch with the src folder because it replace for an empty string but picomatch throw an erro if glob is an empty string. Issue reported: ph1p/vuepress-jsdoc#43
Thank you! I'll take a look at it as soon as I can (: |
Hopefully it's fixed with the new version |
I will test the new version the next weekend, thank you!!! |
This issue was resolved on the last released version but I have a new issue now 😅 |
diegoazh
added a commit
to diegoazh/gmap-vue
that referenced
this issue
Sep 9, 2021
vuepress-jsdoc has an issue with minimatch and picomatch with the src folder because it replace for an empty string but picomatch throw an erro if glob is an empty string. Issue reported: ph1p/vuepress-jsdoc#43
diegoazh
added a commit
to diegoazh/gmap-vue
that referenced
this issue
Nov 23, 2021
vuepress-jsdoc has an issue with minimatch and picomatch with the src folder because it replace for an empty string but picomatch throw an erro if glob is an empty string. Issue reported: ph1p/vuepress-jsdoc#43
diegoazh
added a commit
to diegoazh/gmap-vue
that referenced
this issue
Nov 23, 2021
vuepress-jsdoc has an issue with minimatch and picomatch with the src folder because it replace for an empty string but picomatch throw an erro if glob is an empty string. Issue reported: ph1p/vuepress-jsdoc#43
diegoazh
added a commit
to diegoazh/gmap-vue
that referenced
this issue
Nov 23, 2021
vuepress-jsdoc has an issue with minimatch and picomatch with the src folder because it replace for an empty string but picomatch throw an erro if glob is an empty string. Issue reported: ph1p/vuepress-jsdoc#43
diegoazh
added a commit
to diegoazh/gmap-vue
that referenced
this issue
Nov 23, 2021
vuepress-jsdoc has an issue with minimatch and picomatch with the src folder because it replace for an empty string but picomatch throw an erro if glob is an empty string. Issue reported: ph1p/vuepress-jsdoc#43
diegoazh
added a commit
to diegoazh/gmap-vue
that referenced
this issue
Feb 11, 2022
vuepress-jsdoc has an issue with minimatch and picomatch with the src folder because it replace for an empty string but picomatch throw an erro if glob is an empty string. Issue reported: ph1p/vuepress-jsdoc#43
diegoazh
added a commit
to diegoazh/gmap-vue
that referenced
this issue
Feb 11, 2022
vuepress-jsdoc has an issue with minimatch and picomatch with the src folder because it replace for an empty string but picomatch throw an erro if glob is an empty string. Issue reported: ph1p/vuepress-jsdoc#43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
On commit 554f804ec133a94db99a22eb5f1b110817a214452ce1868738fa5321237ce7a7 the line 81 on
cmds/index.js
changes fromto
the problem is when the source folder is
./src
it replace it for an empty string (''
) andmicromatch
usepicomatch
under the hood:and as you can see in line 47 of the next image if
glob
argument is equal to''
it throws an error and brokes the processOk, the question probably is why it is receiving the empty string on the
glob
ofpicomatch
, is because in the change mentioned above, thesrcFolder
is replaced with''
and in the first iteration the variablefolder
is the default value for the--source
argument, I mean./src
, you can check that in the following imageTo Reproduce
Steps to reproduce the behavior:
Is simple you need a repo with the following structure:
and run the following command
npx vuepress-jsdoc
Expected behavior
Works normally like as
v3.2.0
worked before the mentioned change.Node (please complete the following information):
v14.17.1
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: