Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORF_ID missing once RGI report hAMRonized #58

Closed
SvetlanaUP opened this issue Apr 27, 2021 · 1 comment
Closed

ORF_ID missing once RGI report hAMRonized #58

SvetlanaUP opened this issue Apr 27, 2021 · 1 comment
Labels
bug Something isn't working p0

Comments

@SvetlanaUP
Copy link

Hi Finlay,

when running ORFs through the RGI-hARMonization pipeline, the ORF_ID (important for final hAMR report) is skipped.

Here https://github.com/SvetlanaUP/hAMRonization/blob/master/hAMRonization/RgiIO.py
you can see that I fixed ORF_ID self.field_mapping manually (Fixed 'ORF_ID': 'None', 'Contig': 'input_sequence_id' (should be opposite) ).

This solution works for us, but maybe for the future would be good to have it defined in the RgiIO.py, e.g. if there is no 'Contig' use 'ORF_ID'.

Thanks,
Svetlana

@fmaguire
Copy link
Member

Ah yes, good catch, should add a conditional and a test set for RGI in ORF mode. @raphenya you totally swamped right now or would you have a chance to add that?

@cimendes cimendes added the bug Something isn't working label Oct 12, 2021
@cimendes cimendes added the p0 label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0
Projects
None yet
Development

No branches or pull requests

3 participants