Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assembly_stats_txt.py does not return error code #93

Closed
peterjc opened this issue May 14, 2018 · 1 comment
Closed

assembly_stats_txt.py does not return error code #93

peterjc opened this issue May 14, 2018 · 1 comment

Comments

@peterjc
Copy link

peterjc commented May 14, 2018

Currently code is:

https://github.com/phac-nml/galaxy_tools/blob/master/tools/assemblystats/assembly_stats_txt.py#L18

def stop_err(msg):
    sys.stderr.write('%s\n' % msg)
    sys.exit()

This will return a zero exit level, i.e. no error will be report by Galaxy.

Quick fix:

def stop_err(msg):
    sys.stderr.write('%s\n' % msg)
    sys.exit(1)

Better fix, replace all calls to stop_err with sys.exit which will accept a string, print this to stderr, and exit with return code one.

mgopez pushed a commit that referenced this issue May 27, 2020
* Rewrote Python script for Python 3 compatibility
* Renamed README to README.rst
* Bumped version to 1.1.0
* Returns error code from .pl file, and reason
* Update to gnuplot 5.2.7
mgopez pushed a commit that referenced this issue May 27, 2020
* Rewrote Python script for Python 3 compatibility
* Renamed README to README.rst
* Bumped version to 1.1.0
* Returns error code from .pl file, and reason
* Update to gnuplot 5.2.7
mgopez pushed a commit that referenced this issue May 27, 2020
* Rewrote Python script for Python 3 compatibility
* Renamed README to README.rst
* Bumped version to 1.1.0
* Returns error code from .pl file, and reason
* Update to gnuplot 5.2.7
ericenns pushed a commit that referenced this issue May 29, 2020
* #190, #95, #94, #93, #191

* Rewrote Python script for Python 3 compatibility
* Renamed README to README.rst
* Bumped version to 1.1.0
* Returns error code from .pl file, and reason
* Update to gnuplot 5.2.7

* Address linting errors

* Add Python 3 to dependencies, fix formatting

* Argument ordering

* Downgrade to python 3.7.6

* Add strict channel priority

* Conda Solving Env Fix

conda/conda#5536

* Add travis wait for 30 minutes for planemo

* Remove travis wait, re-order channels

* Use python 3.7.3

* Revert .travis.yml, remove Python 3 as dep

* bump bioperl to work on travis

* Add python 3.7.6 to requirements

Co-authored-by: Matt <matthew.gopez@canada.ca>
Co-authored-by: Darian <46600008+DarianHole@users.noreply.github.com>
Co-authored-by: Darian Hole <darian.hole@canada.ca>
@mgopez
Copy link
Member

mgopez commented May 29, 2020

Addressed in #193
Returns the actual exit code from the .pl script, and the output as well.

@mgopez mgopez closed this as completed May 29, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants