-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assembly_stats_txt.py does not return error code #93
Comments
Merged
ericenns
pushed a commit
that referenced
this issue
May 29, 2020
* #190, #95, #94, #93, #191 * Rewrote Python script for Python 3 compatibility * Renamed README to README.rst * Bumped version to 1.1.0 * Returns error code from .pl file, and reason * Update to gnuplot 5.2.7 * Address linting errors * Add Python 3 to dependencies, fix formatting * Argument ordering * Downgrade to python 3.7.6 * Add strict channel priority * Conda Solving Env Fix conda/conda#5536 * Add travis wait for 30 minutes for planemo * Remove travis wait, re-order channels * Use python 3.7.3 * Revert .travis.yml, remove Python 3 as dep * bump bioperl to work on travis * Add python 3.7.6 to requirements Co-authored-by: Matt <matthew.gopez@canada.ca> Co-authored-by: Darian <46600008+DarianHole@users.noreply.github.com> Co-authored-by: Darian Hole <darian.hole@canada.ca>
Addressed in #193 |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently code is:
https://github.com/phac-nml/galaxy_tools/blob/master/tools/assemblystats/assembly_stats_txt.py#L18
This will return a zero exit level, i.e. no error will be report by Galaxy.
Quick fix:
Better fix, replace all calls to
stop_err
withsys.exit
which will accept a string, print this to stderr, and exit with return code one.The text was updated successfully, but these errors were encountered: