Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/irida newer galaxy #1402

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

apetkau
Copy link
Member

@apetkau apetkau commented Nov 3, 2022

Description of changes

Added a "deferred" state in the allowable states from the Galaxy API for datasets in a Galaxy history. This fixes an issue with communication between IRIDA and newer versions of Galaxy.

If you wished to directly test, you would have to first install a new version of Galaxy (I used 22.05) and configure to run data analysis pipelines for IRIDA. Then try to run a pipeline. Prior to this fix, running pipelines will not work but after this fix they do work.

Related issue

Fixes #1401

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • [ ] User documentation updated for UI or technical changes.

@apetkau apetkau changed the base branch from development to master November 3, 2022 17:24
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I did not test this locally, but I did verify that the newly added state matches the state in the galaxy source code. As such I am going to accept this PR. Thanks @apetkau

@ericenns ericenns merged commit 8af8892 into phac-nml:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use IRIDA with newer versions of Galaxy
2 participants