Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/linting #37

Merged
merged 16 commits into from
Mar 8, 2024
Merged

Add/linting #37

merged 16 commits into from
Mar 8, 2024

Conversation

apetkau
Copy link
Member

@apetkau apetkau commented Mar 7, 2024

  • Adds GitHub action to run nf-core lint
  • Fixes some of the linting issues
  • Configures other issues to be ignored. They will still be included in a PR comment so they are visible and we can slowly start addressing them.
  • Removed unneeded defaults in nextflow_schema.json

@apetkau apetkau changed the title Add/linting WIP:Add/linting Mar 7, 2024
@apetkau apetkau marked this pull request as draft March 7, 2024 22:03
@apetkau apetkau changed the title WIP:Add/linting Add/linting Mar 7, 2024
@apetkau apetkau marked this pull request as ready for review March 7, 2024 22:44
@apetkau apetkau marked this pull request as draft March 7, 2024 22:51
Copy link

github-actions bot commented Mar 8, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit aee9847

+| ✅  75 tests passed       |+
#| ❔  31 tests were ignored |#
!| ❗ 459 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-mikrokondo_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-mikrokondo_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-mikrokondo_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: docs/output.md
  • files_exist - File is ignored: docs/README.md
  • files_exist - File is ignored: docs/usage.md
  • nextflow_config - nextflow_config
  • files_unchanged - File does not exist: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/feature_request.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-mikrokondo_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-mikrokondo_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-mikrokondo_logo_dark.png
  • files_unchanged - File does not exist: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/mikrokondo/mikrokondo/.github/workflows/awstest.yml
  • schema_params - schema_params
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-03-08 16:03:52

@apetkau apetkau marked this pull request as ready for review March 8, 2024 16:06
@apetkau apetkau requested a review from mattheww95 March 8, 2024 16:08
@apetkau apetkau merged commit f27fc49 into dev Mar 8, 2024
4 checks passed
@apetkau apetkau deleted the add/linting branch March 8, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants