Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating Update #13

Merged
merged 3 commits into from
Dec 27, 2011
Merged

Rating Update #13

merged 3 commits into from
Dec 27, 2011

Conversation

neocotic
Copy link
Contributor

I've changed lots to do with updating extension ratings but here's a summary;

  • Average rating shown in popup is now derived from the correct (and up-to-date) location
  • Since a rating breakdown is no longer possible I've replaced the rating tooltip with a diff (similar to the users field)
  • Latest reviews/comments are now sourced correctly and will update
  • Rating column is now named Ranking to avoid confusion with the Ratings column
  • Fixed a bug that could prevent the update button reaching 100%

I did find a call that could contain the details required but there's no real way of programmatically constructing the parameters the service requires. Also, the result itself is confusing and it would be hard to breakdown. However, it's usually the second call to /reviews/components from an extension's page if someone else wants to have a look.

Considering the data currently displayed is out-of-date and misleading I hope you agree that this is the best way forward.

@hansifer
Copy link

Sweet, thanks!

I assume your first bullet ("Average rating shown in popup is now derived from the correct (and up-to-date) location") also applies to the rating count?

@neocotic
Copy link
Contributor Author

That's right! Everything now reflects what's seen on your extensions page.

phaistonian added a commit that referenced this pull request Dec 27, 2011
@phaistonian phaistonian merged commit 87f148a into phaistonian:master Dec 27, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants