Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Di->remove doesn't work #14396

Closed
ruudboon opened this issue Sep 21, 2019 · 1 comment
Closed

[BUG]: Di->remove doesn't work #14396

ruudboon opened this issue Sep 21, 2019 · 1 comment
Labels
bug A bug report status: low Low
Projects
4.0.0 Release

Comments

@ruudboon
Copy link
Member

ruudboon commented Sep 21, 2019 •
edited

Describe the bug
When using di->remove('test') $di->has('test') will return true on the object

To Reproduce

Provide output if related. Provide coredump if any. Use

$di->set('escaper', Escaper::class);

$I->assertCount(1, $di->getServices());

$di->remove('escaper');
$I->assertFalse($di->has('escaper'));

See also #14176

Related to zephir-lang/zephir#1259
@ruudboon ruudboon added this to To do in 4.0.0 Release via automation Sep 21, 2019
This was referenced Sep 21, 2019
Closed
Merged
@ruudboon ruudboon moved this from To do to In progress in 4.0.0 Release Sep 21, 2019
niden added a commit that referenced this issue Sep 22, 2019
@niden
Merge branch 'di-remove-14396' of https://github.com/ruudboon/cphalcon …
aadeeca 
…into ruudboon-di-remove-14396

* 'di-remove-14396' of https://github.com/ruudboon/cphalcon:
  Updated changelog
  Fixed remove() not removing service #14396
niden added a commit that referenced this issue Sep 22, 2019
@niden
Merge branch 'ruudboon-di-remove-14396' into 4.0.x
8cb8ee6 
* ruudboon-di-remove-14396:
  Updated changelog
  Fixed remove() not removing service #14396
@niden
Copy link
Sponsor Member

niden commented Sep 22, 2019

Resolved

@niden niden closed this as completed Sep 22, 2019
4.0.0 Release automation moved this from In progress to Done Sep 22, 2019
niden added a commit that referenced this issue Sep 22, 2019
@niden
Merge branch '4.0.x' into master-check
874e4f1 
* 4.0.x: (202 commits)
  Updated changelog
  Changing the interface to return null for getEventsManager
  Correcting interface
  Correcting tests
  Fixed Firewall\Adapter\AbstractAdapter::setEventsManager
  Remove void return type for constructors
  Fixed return types for various methods to satisfy interface declaration
  Constructors should never declare return type [skip appveyor]
  Updated changelog
  Styling fix changelog
  Fixed remove() not removing service #14396
  Forgot to push changelog
  Use write connection on create to prevent replica lag. Fix #14256
  Added license information in README
  Moved license files to 3rdparty/license. Added more licenses
  Update issue templates
  Backup old template file
  Update issue templates
  [4.0.x] - Corrected test
  [4.0.x] - Fixing stupid error
  ...
sergeyklay pushed a commit that referenced this issue Sep 24, 2019
@ruudboon @sergeyklay
Fixed remove() not removing service #14396
cbdb9c4
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug report status: low Low
Projects
No open projects
4.0.0 Release
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niden @ruudboon