Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Di->remove doesn't work #14396

Closed
ruudboon opened this issue Sep 21, 2019 · 1 comment
Labels
Projects

Comments

@ruudboon
Copy link
Member

@ruudboon ruudboon commented Sep 21, 2019

Describe the bug
When using di->remove('test') $di->has('test') will return true on the object

To Reproduce

Provide output if related. Provide coredump if any. Use

$di->set('escaper', Escaper::class);

$I->assertCount(1, $di->getServices());

$di->remove('escaper');
$I->assertFalse($di->has('escaper'));

See also #14176

Related to phalcon/zephir#1259

@ruudboon ruudboon added this to To do in 4.0 Release via automation Sep 21, 2019
ruudboon added a commit to ruudboon/cphalcon that referenced this issue Sep 21, 2019
This was referenced Sep 21, 2019
@ruudboon ruudboon moved this from To do to In progress in 4.0 Release Sep 21, 2019
niden added a commit that referenced this issue Sep 22, 2019
…into ruudboon-di-remove-14396

* 'di-remove-14396' of https://github.com/ruudboon/cphalcon:
  Updated changelog
  Fixed remove() not removing service #14396
niden added a commit that referenced this issue Sep 22, 2019
* ruudboon-di-remove-14396:
  Updated changelog
  Fixed remove() not removing service #14396
@niden

This comment has been minimized.

Copy link
Member

@niden niden commented Sep 22, 2019

Resolved

@niden niden closed this Sep 22, 2019
4.0 Release automation moved this from In progress to Done Sep 22, 2019
niden added a commit that referenced this issue Sep 22, 2019
* 4.0.x: (202 commits)
  Updated changelog
  Changing the interface to return null for getEventsManager
  Correcting interface
  Correcting tests
  Fixed Firewall\Adapter\AbstractAdapter::setEventsManager
  Remove void return type for constructors
  Fixed return types for various methods to satisfy interface declaration
  Constructors should never declare return type [skip appveyor]
  Updated changelog
  Styling fix changelog
  Fixed remove() not removing service #14396
  Forgot to push changelog
  Use write connection on create to prevent replica lag. Fix #14256
  Added license information in README
  Moved license files to 3rdparty/license. Added more licenses
  Update issue templates
  Backup old template file
  Update issue templates
  [4.0.x] - Corrected test
  [4.0.x] - Fixing stupid error
  ...
sergeyklay added a commit that referenced this issue Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4.0 Release
  
Done
2 participants
You can’t perform that action at this time.