T13655 DI::getServices unit tests

[emiliodeg]

Hello!

• Type: code quality
• Link to issue: Refactor Unit Tests - Add more tests #13655

In raising this pull request, I confirm the following:

• I have read and understood the Contributing Guidelines
• I have checked that another pull request for this purpose does not exist
• I wrote some tests for this PR
• I have updated the relevant CHANGELOG
• I have created a PR for the documentation about this change

Small description of change:
I just added DI::getServices unit tests
Thanks

[emiliodeg]

As I thought there is a problem with zephir and unset on arrays

Di::remove() doesn't work as expected

[emiliodeg]

Here the Zephir bug zephir-lang/zephir#1259

[sergeyklay]

@emiliodeg Try again after #14191

[sergeyklay]

Declaration of:

Phalcon\Validation\ValidatorComposite::validate(Phalcon\Validation\Validation $validation, $field): bool

must be compatible with

Phalcon\Validation\Validator::validate(Phalcon\Validation $validation, $field): bool 

Declaration of

Phalcon\Validation\Validator\File::getValidators()

must be compatible with

Phalcon\Validation\ValidatorCompositeInterface::getValidators(): array

Declaration of:

Phalcon\Validation\Validator\StringLength::getValidators()

must be compatible with

Phalcon\Validation\ValidatorCompositeInterface::getValidators(): array 

and so on

[niden]

@emiliodeg can you rebase this please?

[emiliodeg]

Yes I'm working on it

[emiliodeg]

Well the unset bug is still there

[sergeyklay]

I did'n see any segfault. Are you sure about unset bug?

[emiliodeg]

I've been making some tests but I still getting problems

namespace Phalcon;

class Test {

    public function __construct()
    {
        var a, key;
        array b = [];

        // a like a var
        let a["key"] = 1234;
        var_dump(a, count(a)); // get UNKNOWN and 1

        unset a["key"];
        var_dump(a, count(a));  // get UNKNOWN and 1 <<< must be 0

        let key = "other";
        let a[key] = "bar";
        var_dump(a, count(a)); // get UNKNOWN and 1

        unset a[key];
        var_dump(a, count(a));  // get UNKNOWN and 1 <<< must be 0

        // b like an array
        var_dump(b, count(b)); // get UNKNOWN and 1 <<< must be 0

        let b["key"] = 1234;
        var_dump(b, count(b));// get UNKNOWN and 1

        unset b["key"];
        var_dump(b, count(b));// get UNKNOWN and 1 <<< must be 0

        let key = "other";
        let b[key] = "bar";
        var_dump(b, count(b));// get UNKNOWN and 1 <<< must be 0

        unset b[key];
        var_dump(b, count(b)); // get UNKNOWN and 1 <<< must be 0
    }
}

I don't know maybe is a problem with count()

[sergeyklay]

@emiliodeg Could you please open an issue at Zephir with simple steps to reproduce (not a whole framework)?

[ruudboon]

@emiliodeg Did you already tested this with the latest Zephir?

[emiliodeg]

I'm so sorry but I didn't have time yet. I'll try this weekend

[ruudboon]

@emiliodeg closing this pull in favour of #14396. I included your tests, fix will be in soon. Thnx!